Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for grouping code blocks / contexts in editor (folding) #251

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

Spejbl
Copy link
Contributor

@Spejbl Spejbl commented Nov 19, 2018

Description of the Change

Allow code folding in editor.

Benefits

Improves working with larger files.

Verification Process

Open any file - hover on line number - icon of folding should show up

folding

Github Issues

Resolves #230

Copy link
Contributor

@filippsen filippsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default parameter for the folding controls is apparently set to mouseover, which can be good for those who don't care about it (easier to ignore).
The only possible downside I can see is the new column (the reserved space for the new "+" icon) taking a few pixels away from those who don't see any benefits.

Resolves 230. OK
I consider this a welcome addition. OK!

@javier-tarazaga
Copy link
Contributor

@Spejbl This is great and really welcomed!

@Spejbl
Copy link
Contributor Author

Spejbl commented Nov 20, 2018

We could add (later on) an option in Preferences to turn off code folding, to solve that reserved space column.

@Spejbl Spejbl merged commit c6d76b4 into SuperblocksHQ:master Nov 20, 2018
@Spejbl Spejbl deleted the allow-folding-code-blocks branch December 10, 2018 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for grouping code blocks / contexts in editor (folding)
3 participants