Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract file name length validation exceeded #183

Merged
merged 6 commits into from
Oct 5, 2018
Merged

Contract file name length validation exceeded #183

merged 6 commits into from
Oct 5, 2018

Conversation

waheed25
Copy link
Contributor

this closes #172

javier-tarazaga
javier-tarazaga previously requested changes Sep 24, 2018
View reviewed changes
Copy link
Contributor

@javier-tarazaga javier-tarazaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This task is not completed. You just changed the one in contro.js but what about the one in the editor-contract.js file?

@waheed25
Copy link
Contributor Author

Changed in editor-contract file.

filippsen
filippsen approved these changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@filippsen filippsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name length has been limited to 255 characters when creating a New contract. OK!

File name length has been limited to 255 characters when renaming contract via Configure. OK!

OK!

@filippsen filippsen dismissed javier-tarazaga’s stale review October 5, 2018 13:03

Commit a0d6f88, submitted after this review, resolves the requested change

@waheed25 waheed25 merged commit 1d9a3ca into master Oct 5, 2018
@filippsen filippsen mentioned this pull request Oct 5, 2018
Merged
@javier-tarazaga javier-tarazaga deleted the contract-name-length branch October 8, 2018 07:52
@filippsen filippsen mentioned this pull request Oct 15, 2018
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filippsen filippsen filippsen approved these changes

@javier-tarazaga javier-tarazaga javier-tarazaga left review comments

@bashlund bashlund Awaiting requested review from bashlund

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider increasing or removing contract file name length
3 participants
@waheed25 @filippsen @javier-tarazaga