Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase deployer gas limit #173

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Conversation

filippsen
Copy link
Contributor

Description of the Change

This change bumps the default gas limit used for deployment from 3900000 to 7900000.

Alternate Designs

Not applicable.

Benefits

The original value was set to the maximum block gas limit value observed at the time. The network has evolved since then and the current observable block gas limit is close to 8 million now.

This new value is slightly below the current observable block gas limit in all networks (except Rinkeby, currently in the lower 7000000 bound).

Possible Drawbacks

Apparently none.

Verification Process

Deploy output now reads:

Gaslimit=0x788B60, gasPrice=0x3B9ACA00.

Github Issues

Resolves #111

@filippsen filippsen merged commit 954925d into SuperblocksHQ:master Sep 17, 2018
@filippsen filippsen mentioned this pull request Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Gas limit cap is way too low for larger Smart Contracts
2 participants