Renaming issue #168
Merged
Renaming issue #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Closes all open windows associated with contract
filippsen
previously approved these changes
Sep 16, 2018
There was a problem hiding this comment.
This request resolves issue #99:
- Project tabs gets automatically closed when saving. The Please close any [...] window alert has been removed;
- If open, the contract file to be renamed gets automatically closed instead of requiring explicit action by the user;
- Failed to reproduce the problem as initially described in Add ability to rename a contract file #99 [1]. OK!
- Reference tests Test 1, Test 2, Test 3 and Test 4 [2] are working, without the need to manually close
HelloWorld.solbefore saving. OK!
OK!
This request also solves issue #110:
- The relevant project tabs get automatically closed when deleting a file.
OK!
This request also solves issue #157:
- Error checking added to
contractinteraction.js
OK!
Other/code review:
- Unused code has been removed (
projectname); - Maximum length when renaming has been set to 16 characters;
OK!
[1]
- Create a New project from Hello World template.
- Now, proceed with the following actions, always accessing it from the left side menu:
- Expand
HelloWorld.solin the Files hierarchy; - Click Configure: rename
HelloWorldtob. Save; - Expand
b.sol; - Click Configure. Do nothing. Leave the tab open.
- Click Compile. Leave the tab open. (Could also be triggered from the editor menu)
- Click Deploy. Leave the tab open. (Could also be triggered from the editor menu)
- Click Configure. Rename back to
HelloWorld
[2] Please refer to section Current state in issue #99
| @@ -145,8 +149,8 @@ export default class ContractEditor extends Component { | |||
| alert('Error: Missing fields.'); | |||
| return; | |||
| } | |||
| if(!this.contract.obj.name.match(/^([a-zA-Z0-9-_]+)$/)) { | |||
| alert('Illegal contract name. Only A-Za-z0-9, dash (-) and underscore (_) allowed.'); | |||
| if(!this.contract.obj.name.match(/^([a-zA-Z0-9-_]+)$/) || this.contract.obj.name.length > 16) { | |||
There was a problem hiding this comment.
@bashlund I still believe we shouldn't make the decision for the user, restricting how long SC name can it be.
javier-tarazaga
added
the
Plan Item
javier-tarazaga
approved these changes
Sep 17, 2018
This was referenced Sep 17, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should sort out the contract renaming issue we've been having.
Contract names are only 16 characters max length in this version since that's the current format, which we likely will extend later on.