This repository has been archived by the owner on Jul 29, 2023. It is now read-only.
Comments load after YouTube's custom navigation #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See http://youtube.github.io/spfjs/documentation/events/. The `spfdone` event is fired when YouTube completes an internal page load. Fixes SuperManifolds#194.
|
On closer inspection, this solution is clunky and inefficient. The event listener should really be added in the Application constructor, in place of the mutation observer. Otherwise, I'm just loading a new copy of the extension every time the user navigates to a new page. Give me some time to work on this, or feel free to do it yourself. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://youtube.github.io/spfjs/documentation/events/.
The
spfdoneevent is fired when YouTube completes an internal page load.Fixes #194.