Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set NumberOfResolutions = 3 by default, throw exception if NumberOfResolutions is 0 #859

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

N-Dekker
Copy link
Member

@N-Dekker N-Dekker commented Mar 27, 2023

Following commit f84ac0d "ENH: First checkin of a generic pyramid...", February 2, 2012.

Addressed issue #858 MovingImagePyramidBase, FixedImagePyramidBase have different defaults for "NumberOfResolutions"

Following commit f84ac0d "ENH: First checkin of a generic pyramid...", February 2, 2012.

Addressed issue #858 MovingImagePyramidBase, FixedImagePyramidBase have different defaults for "NumberOfResolutions"
@N-Dekker N-Dekker force-pushed the MovingImagePyramidBase-default-NumberOfResolutions branch 2 times, most recently from 2cceb64 to 9b2b22c Compare March 27, 2023 17:14
Distinguished clearly between zero and one. In this case, the value zero must be a mistake.

Improved consistency between fixed and moving pyramid.

Discussed at our weekly internal elastix sprint meeting.
@N-Dekker N-Dekker force-pushed the MovingImagePyramidBase-default-NumberOfResolutions branch from 9b2b22c to b2de05f Compare March 27, 2023 19:37
@N-Dekker N-Dekker changed the title BUG: Set NumberOfResolutions = 3 by default, in MovingImagePyramidBase Set NumberOfResolutions = 3 by default, throw exception if NumberOfResolutions is 0 Mar 28, 2023
@N-Dekker N-Dekker merged commit 28be9d5 into main Mar 28, 2023
@N-Dekker N-Dekker deleted the MovingImagePyramidBase-default-NumberOfResolutions branch March 28, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MovingImagePyramidBase, FixedImagePyramidBase have different defaults for "NumberOfResolutions"
1 participant