PERF: GenerateData() should not set "WriteResultImage" (issue #370) #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-Dekker
force-pushed
the
GenerateData-no-longer-set-WriteResultImage-true
branch
from
828f820 to
e47fc12
Compare
Both `ElastixFilter::GenerateData()` and `ElastixRegistrationMethod::GenerateData()` did overwrite a user preference by explicitly setting the "WriteResultImage" parameter. This behavior was added with commit a6e8f10 "ENH: Add ElastixFilter support for initial transform parameter file" by Kasper Marstal, 3 February 2016. Which causes a performance issue, #370 "Final image transformation takes long time", reported by orange676. With this commit these `GenerateData()` member functions longer set "WriteResultImage". When the value of this parameter is false, the elastix library will no longer generate a result image; `GetOutput()` will return an empty image. Discussed at the internal elastix sprint of 7 June 2021, with Marius, Stefan, and Viktor.
N-Dekker
force-pushed
the
GenerateData-no-longer-set-WriteResultImage-true
branch
from
e47fc12 to
2115035
Compare
N-Dekker
changed the title
GenerateData() no longer set "WriteResultImage" (issue #370)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
ElastixFilter::GenerateData()andElastixRegistrationMethod::GenerateData()did overwrite a user preference by explicitly setting the "WriteResultImage" parameter. This behavior was added with commit a6e8f10 "ENH: Add ElastixFilter support for initial transform parameter file" by Kasper Marstal (@kaspermarstal), 3 February 2016.Which causes a performance issue, #370 "Final image transformation takes long time", reported by @orange676.
With this commit these
GenerateData()member functions longer set "WriteResultImage". When the value of this parameter is false, the elastix library will no longer generate a result image;GetOutput()will return an empty image.Discussed at the internal elastix sprint of 7 June 2021, with Marius (@mstaring), Stefan (@stefanklein), and Viktor (@ViktorvdValk).