Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add MultiBSplineTransformWithNormalLabels to parameter map #392

Merged

Conversation

N-Dekker
Copy link
Member

Added "MultiBSplineTransformWithNormalLabels" to the transform parameter map of MultiBSplineTransformWithNormal, addressing a "TODO" comment.

Anticipating pull request #385 "Sync Transform WriteToFile with CreateTransformParametersMap".

Also improved the Test_CreateTransformParametersMap_for_default_transform() unit test function for MultiBSplineTransformWithNormal. Note that this change is not yet completely unit tested, because MultiBSplineTransformWithNormal::BeforeAll() throws an exception, saying "ERROR: Missing -labels argument!".

Added "MultiBSplineTransformWithNormalLabels" to the transform parameter map of `MultiBSplineTransformWithNormal`, addressing a "TODO" comment.

Anticipating pull request #385 "Sync Transform WriteToFile with CreateTransformParametersMap".

Also improved the `Test_CreateTransformParametersMap_for_default_transform()` unit test function for `MultiBSplineTransformWithNormal`. Note that this change is not yet completely unit tested, because `MultiBSplineTransformWithNormal::BeforeAll()` throws an exception, saying "ERROR: Missing -labels argument!".
@N-Dekker N-Dekker marked this pull request as ready for review January 14, 2021 16:47
@N-Dekker N-Dekker merged commit 57dcf37 into develop Jan 14, 2021
@N-Dekker N-Dekker deleted the Add-MultiBSplineTransformWithNormalLabels-to-parameter-map branch January 14, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant