Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Switch off ELASTIX_USE_OPENMP by default #1186

Closed
wants to merge 1 commit into from

Conversation

N-Dekker
Copy link
Member

@N-Dekker N-Dekker commented Jul 5, 2024

The use of OpenMP may interfere with the use of ITK's MultiThreader.

The use of OpenMP may interfere with the use of ITK's MultiThreader.
@N-Dekker
Copy link
Member Author

N-Dekker commented Jul 5, 2024

For the record, previous pull requests on OpenMP where specifically about MacOS:


The option ELASTIX_USE_OPENMP was added by commit b529a98, "Add CMake option for disabling OpenMP", Kasper (@kaspermarstal), May 2, 2017 but then it was still ON by default.

@N-Dekker N-Dekker requested review from mstaring and stefanklein July 5, 2024 13:28
N-Dekker added a commit to N-Dekker/ITKElastix that referenced this pull request Jul 5, 2024
- Including pull request SuperElastix/elastix#1186
"BUG: Switch off ELASTIX_USE_OPENMP by default"
@N-Dekker N-Dekker marked this pull request as ready for review July 7, 2024 12:04
@N-Dekker
Copy link
Member Author

N-Dekker commented Jul 7, 2024

@N-Dekker
Copy link
Member Author

N-Dekker commented Jul 8, 2024

Pull request abandoned: will instead simply remove the OpenMP option.

@N-Dekker N-Dekker closed this Jul 8, 2024
@N-Dekker N-Dekker deleted the Switch-off-ELASTIX_USE_OPENMP branch July 9, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant