Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add support ComputeZYX parameter to EulerStackTransform (for 3D) #1155

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

N-Dekker
Copy link
Member

Supports specifying parameter (ComputeZYX "true"), when the transform is "EulerStackTransform" and the image stack is 4D (meaning that the images are 3D).

Triggered by a question from Laurens Beljaards.

@N-Dekker N-Dekker requested a review from stefanklein June 14, 2024 10:32
@N-Dekker
Copy link
Member Author

It appears that this ITK Euler3DTransform bug fix should be included with elastix AdvancedEuler3DTransform as well: "BUG: Interpretation of the Euler angles ZYX or ZXY was not exported.", Ziv Yaniv (@zivy), May 9, 2016, InsightSoftwareConsortium/ITK@47c2491

(elastix AdvancedEuler3DTransform is still from 2009, so it did not yet have this ITK Euler3DTransform fix from 2016.)

N-Dekker added 2 commits June 20, 2024 16:59
Supports specifying parameter `(ComputeZYX "true")`, when the transform is "EulerStackTransform" and the image stack is 4D (meaning that the images are 3D).

Tested that ComputeZYX = true yields a different result than ComputeZYX = false.

Triggered by a mail from Laurens Beljaards, subject "Elastix vraag", 10 June 2024.
@N-Dekker N-Dekker force-pushed the ComputeZYX-EulerStackTransform branch from 7ee23b0 to 8f7c1a0 Compare June 20, 2024 17:18
@N-Dekker N-Dekker marked this pull request as ready for review June 20, 2024 17:22
@N-Dekker N-Dekker merged commit 8111c67 into main Jun 20, 2024
7 of 8 checks passed
@N-Dekker N-Dekker deleted the ComputeZYX-EulerStackTransform branch June 20, 2024 18:12
N-Dekker added a commit to N-Dekker/ITKElastix that referenced this pull request Jun 20, 2024
Including:

 - pull request SuperElastix/elastix#1155
 commit SuperElastix/elastix@8111c67
 ENH: Add support ComputeZYX parameter to EulerStackTransform (for 3D)

And many more commits (366 commits ahead of https://github.com/thewtex/elastix/tree/ITKElastix-2023-01-01-022aa6cd)
N-Dekker added a commit to N-Dekker/ITKElastix that referenced this pull request Jul 9, 2024
Including:

 - pull request SuperElastix/elastix#1188
 commit SuperElastix/elastix@e49c47f
 STYLE: Remove unused ELASTIX_USE_OPENMP option and OpenMP compiler flags

 - pull request SuperElastix/elastix#1155
 commit SuperElastix/elastix@8111c67
 ENH: Add support ComputeZYX parameter to EulerStackTransform (for 3D)

And many more commits (400+ commits ahead of https://github.com/thewtex/elastix/tree/ITKElastix-2023-01-01-022aa6cd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant