Update to sql-bricks 3.0 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Suor: This pull request updates sql-bricks-postgres to use the newly-published sql-bricks 3.0. The main advantage of 3.0 is that it removes the underscore dependency (it was depending on an old version that had security vulnerabilities).
v3.0 is much less ambitious than originally planned. The main thing done (besides the removal of Underscore) is the removal of the mini-templating language, in favor of Javascript's built-in template literals. This required some changes to sql-bricks-postgres (included in this pull request).
I got the sql-bricks-postgres tests all passing and I have one project that depends on it and verified that its tests are all passing. That said, if you have any projects that depend on sql-bricks-postgres, it'd be comforting to know that their tests pass with these changes before publishing this to npm (perhaps as version
1.0.0or0.6.0?)