-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secor file pattern issue fixes for Azure #1643
Merged
sowmya-dixit
merged 69 commits into
Sunbird-Obsrv:release-5.2.0
from
sowmya-dixit:release-5.2.0
Jun 4, 2024
Merged
Secor file pattern issue fixes for Azure #1643
sowmya-dixit
merged 69 commits into
Sunbird-Obsrv:release-5.2.0
from
sowmya-dixit:release-5.2.0
Jun 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added cloud_storage_privatereports_bucketname variable
…pipeline into release-5.2.0
…-pipeline into release-5.2.0
…-pipeline into release-5.2.0
…-pipeline into release-5.2.0
…-pipeline into release-5.2.0
…-pipeline into release-5.2.0
…-pipeline into release-5.2.0
AmiableAnil
reviewed
Jun 4, 2024
@@ -48,6 +48,7 @@ cloud_storage: | |||
provider: "azure" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use cloud_service_provider
instead of hardcoding it
AmiableAnil
reviewed
Jun 4, 2024
@@ -48,6 +48,7 @@ cloud_storage: | |||
provider: "azure" | |||
account_name: "{{cloud_public_storage_accountname}}" | |||
account_key: "{{cloud_public_storage_secret}}" | |||
account_endpoint: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the cloud_public_storage_endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please choose appropriate options.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: