Issue #SB-29145 feat: Added Question & QuestionSet Copy APIs With BranchingLogic Copy.

[joffinjoy]

SB-29145 Question Set Copy API fixes

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please choose appropriate options.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Ran Test A
• Ran Test B

Test Configuration:

• Software versions: Java 11, scala-2.11, play-2.7.2
• Hardware versions: 2 CPU/ 4GB RAM

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[krgauraw]

@joffinjoy
Since its major changes for platform, we get this PR reviewed with DC. DC Requested for changes because the implementation approach taken here is not generic in nature and leads to code duplication.

Feedback:

1. We should have a common method implementation which can handle copy operation for nodes which doesn't have hierarchy strucure(e.g: Content, Question)
2. We should have a common method implementation which can handle copy operation for nodes having hierarchal structure (e.g: Collection/QuestionSet)
3. The above method implementations should not be part of specific service. It should be available as a common module (e.g: part of platfrom-modules module). So that any service can use it.

Recommended Action:
Please Prepare an implementation design document by considering above feedback and get it approved by DC.

cc: @pallakartheekreddy @aks30

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

86.9% Coverage
0.0% Duplication