Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "#0000 audio detection feature enabled" #181

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

gouravmore
Copy link
Member

@gouravmore gouravmore commented Oct 22, 2024

Reverts #180

Summary by CodeRabbit

  • New Features

    • Enhanced audio recording functionality in the AudioRecorder component.
    • Improved error handling and feedback in the VoiceAnalyser component.
  • Bug Fixes

    • Updated audio playback error handling for better user experience.
  • Documentation

    • Enforced required prop for isShowCase in the VoiceAnalyser component for better type safety.
  • Chores

    • Updated to modern audio permission API for improved compatibility.

Copy link

coderabbitai bot commented Oct 22, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces changes to two components: AudioRecorder in src/utils/AudioCompare.js and VoiceAnalyser in src/utils/VoiceAnalyser.js. The AudioRecorder component's state management is enhanced with new variables to track recording status and store audio blobs, while the recording and analysis logic is simplified. The VoiceAnalyser component has its prop type requirements updated and features improved error handling and modernized audio permission requests.

Changes

File Change Summary
src/utils/AudioCompare.js - Added state variables: isRecording and audioBlob.
- Updated startRecording to set isRecording to true.
- Removed analyzeAudio function.
- Modified stopRecording to save audio blob directly.
src/utils/VoiceAnalyser.js - Changed isShowCase prop from optional to required.
- Improved error handling in playAudio function.
- Updated fetchASROutput with additional logic.
- Modernized audio permissions using navigator.mediaDevices.getUserMedia.

Possibly related PRs

  • #0000 audio detection feature enabled #180: The changes in this PR also involve the AudioRecorder component in src/utils/AudioCompare.js, specifically modifying the state management and recording functionality, which directly relates to the changes made in the main PR.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gouravmore gouravmore merged commit 0732a28 into all-1.2-tn-dev Oct 22, 2024
Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

bharathrams pushed a commit to Bhashabyasa/nd-all-learner-ai-app that referenced this pull request Nov 25, 2024
…theblanks-all-dev-tn

Revert "#0000 audio detection feature enabled"
bharathrams pushed a commit to Bhashabyasa/nd-all-learner-ai-app that referenced this pull request Dec 2, 2024
…theblanks-all-dev-tn

Revert "#0000 audio detection feature enabled"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant