Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issueid #223945 fix: When user is loggin out we are redirecting to Di… #125

Merged

Conversation

ajinkyapandetekdi
Copy link
Collaborator

@ajinkyapandetekdi ajinkyapandetekdi commented Jul 26, 2024

…sovery start page

Summary by CodeRabbit

  • New Features

    • Added new routing for the root ("/") and login ("/login") pages, enhancing navigation clarity.
    • Updated redirection logic for unauthenticated users to guide them to the login page.
    • Introduced content filtering in the VoiceAnalyser component to remove inappropriate language from responses.
    • Added support for the Gujarati language, expanding the multilingual capabilities of the application.
  • Bug Fixes

    • Corrected case sensitivity issue in logout navigation path to ensure consistent routing behavior.
  • Refactor

    • Simplified routing configuration for easier management of authentication requirements.
    • Streamlined PrivateRoute component by removing unnecessary code.

Copy link

coderabbitai bot commented Jul 26, 2024

Walkthrough

The recent updates enhance the routing and authentication logic within the application. Key changes include the modification of the logout navigation path for consistency, the introduction of new routes for the root and login paths with defined authentication requirements, and streamlined user redirection to ensure unauthenticated users are directed to the login page instead of the homepage. These adjustments improve clarity and user experience related to navigation and authentication flows.

Changes

Files Change Summary
src/components/Assesment/Assesment.jsx, src/routes/index.js, src/views/AppContent/AppContent.jsx Modified navigation paths and routing logic; ensured consistent URL paths, added new routes, and improved redirection for unauthenticated users.
src/utils/VoiceAnalyser.js Introduced filtering of inappropriate content in responses from the VoiceAnalyser component.
src/utils/constants.js Added support for Gujarati language in the constants, enhancing multilingual capabilities.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App
    participant LogoutHandler
    participant AuthHandler

    User->>LogoutHandler: Click Logout
    LogoutHandler->>App: Clear Local Storage
    LogoutHandler->>App: Navigate to "/login"
    App->>User: Redirect to Login Page

    User->>AuthHandler: Access Protected Route
    AuthHandler->>User: Check Authentication
    alt Not Authenticated
        AuthHandler->>User: Redirect to "/login"
    else Authenticated
        AuthHandler->>User: Access Granted
    end
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4923e4e and 8af3f5c.

Files selected for processing (3)
  • src/components/Assesment/Assesment.jsx (1 hunks)
  • src/routes/index.js (5 hunks)
  • src/views/AppContent/AppContent.jsx (1 hunks)
Additional comments not posted (3)
src/routes/index.js (2)

6-11: LGTM!

The root path now consistently requires authentication, improving clarity and security.


61-66: LGTM!

The login path is now explicitly defined and does not require authentication, improving clarity.

src/components/Assesment/Assesment.jsx (1)

502-502: LGTM!

The navigation path change ensures consistency in URL casing, which is important for systems where URLs are case-sensitive.

src/views/AppContent/AppContent.jsx Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8af3f5c and 3630f6e.

Files selected for processing (1)
  • src/utils/VoiceAnalyser.js (2 hunks)
Additional comments not posted (2)
src/utils/VoiceAnalyser.js (2)

115-115: Good addition for content quality.

Filtering bad words from the non-denoised response ensures that inappropriate content is handled properly.


151-151: Good addition for content quality.

Filtering bad words from the denoised response ensures that inappropriate content is handled properly.

Copy link

sonarcloud bot commented Aug 2, 2024

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3630f6e and 529ad8b.

Files selected for processing (1)
  • src/utils/constants.js (1 hunks)
Additional comments not posted (1)
src/utils/constants.js (1)

Line range hint 1-1:
New language entry added correctly.

The new entry for the Gujarati language is correctly formatted and consistent with the existing entries in the AllLanguages array.

@gouravmore gouravmore merged commit 069dc61 into Sunbird-ALL:all-2.0-offline Aug 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants