-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUMO-231087:Alert Grouping Support for Muting schedules: update TF f… #601
SUMO-231087:Alert Grouping Support for Muting schedules: update TF f… #601
Conversation
99575c4
to
243826e
Compare
run the test locally and without error.
|
…r support group key and value
09703cd
to
0f8f4c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments
We can sync up later to look at the failing test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, let's wait for the changes to be available everywhere before we merge this PR.
sumologic/resource_sumologic_muting_schedules_library_muting_schedule_test.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except one minor comment.
…or support group key and value