Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUMO-231087:Alert Grouping Support for Muting schedules: update TF f… #601

Merged

Conversation

jxie418
Copy link
Contributor

@jxie418 jxie418 commented Dec 19, 2023

…or support group key and value

@jxie418 jxie418 force-pushed the SUMO-231087-muting-schedule-group-support-pr-view branch from 99575c4 to 243826e Compare January 8, 2024 19:32
@jxie418
Copy link
Contributor Author

jxie418 commented Jan 8, 2024

run the test locally and without error.

--- PASS: TestAccSumologicMutingSchedulesLibraryMutingSchedule_createWithGroup (2.82s)
PASS
ok  	github.com/SumoLogic/terraform-provider-sumologic/sumologic	3.335s

@jxie418 jxie418 force-pushed the SUMO-231087-muting-schedule-group-support-pr-view branch from 09703cd to 0f8f4c2 Compare January 8, 2024 22:28
Copy link
Collaborator

@sumovishal sumovishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

CHANGELOG.md Outdated Show resolved Hide resolved
website/docs/r/muting_schedule.html.markdown Outdated Show resolved Hide resolved
website/docs/r/muting_schedule.html.markdown Outdated Show resolved Hide resolved
@sumovishal
Copy link
Collaborator

We can sync up later to look at the failing test.

@jxie418 jxie418 requested a review from sumovishal January 12, 2024 16:50
Copy link
Collaborator

@sumovishal sumovishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's wait for the changes to be available everywhere before we merge this PR.

Copy link
Collaborator

@sumovishal sumovishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one minor comment.

website/docs/r/muting_schedule.html.markdown Show resolved Hide resolved
@gchairuangsang gchairuangsang merged commit 165bcce into master Apr 22, 2024
3 checks passed
@gchairuangsang gchairuangsang deleted the SUMO-231087-muting-schedule-group-support-pr-view branch April 22, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants