feat: fetch variables required to submit the image #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominik Rosiek <[email protected]>
scripts/build-push-all.sh
Outdated
Comment on lines
8
to
10
| CHECK="${CHECK:-true}" | ||
| OPERATOR_PROJECT_ID=6075d88c2b962feb86bea730 | ||
|
|
There was a problem hiding this comment.
why do we have a default here and what is it?
There was a problem hiding this comment.
Maybe add a comment here that explains it.
There was a problem hiding this comment.
It's static :D
I will add readonly
added 2 commits
May 28, 2024 14:12
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
sumo-drosiek
commented
May 28, 2024
Signed-off-by: Dominik Rosiek <[email protected]>
sumo-drosiek
force-pushed
the
drosiek-variables
branch
from
2de9d98 to
06fe6ff
Compare
Signed-off-by: Dominik Rosiek <[email protected]>
sumo-drosiek
force-pushed
the
drosiek-variables
branch
from
06fe6ff to
105a36c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.