Add ability to use KMS encrypted endpoint #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhenjes
force-pushed
the
create-kms-decrypt-http-endpoint-method
branch
3 times, most recently
from
357c9ed to
95a249c
Compare
nhenjes
force-pushed
the
create-kms-decrypt-http-endpoint-method
branch
from
95a249c to
30abd3d
Compare
himanshu219
approved these changes
Mar 3, 2023
|
LGTM. We'll be working with doc team to update the docs and then proceed with the new version of the extension. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Add KMS encrypted endpoint URL
Description
This update allows someone to use a KMS encrypted http endpoint by supplying the KMS ciphertext blob and a KMS Key ID. This also implements a basic cache function to minimize the number of calls made to the KMS service. A user can set the cache timeout in seconds based on the volatility of their endpoint secrets.
Related Issue
#21
Checklist