Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abab #56

Merged
merged 9 commits into from
Jan 29, 2024
Merged

Abab #56

merged 9 commits into from
Jan 29, 2024

Conversation

asukaminato0721
Copy link
Contributor

@asukaminato0721 asukaminato0721 commented Jan 27, 2024 •
edited
Loading

@asukaminato0721 asukaminato0721 changed the title Abab Abab && domexception Jan 27, 2024
SukkaW
SukkaW requested changes Jan 29, 2024
View reviewed changes
Copy link
Owner

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOMException was introduced in Node.js 17. IMHO we can't simply do export { DOMException } as nolyfill supports Node.js 12.

@asukaminato0721 asukaminato0721 changed the title Abab && domexception Abab Jan 29, 2024
SukkaW
SukkaW previously approved these changes Jan 29, 2024
View reviewed changes
SukkaW
SukkaW reviewed Jan 29, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@SukkaW SukkaW merged commit c097bea into SukkaW:master Jan 29, 2024
1 check passed
@asukaminato0721 asukaminato0721 deleted the abab branch January 29, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asukaminato0721 @SukkaW