hotfix/SUIT-20450 - compatibility of nodejs v.20 with mock-fs was partial fixed. Some part of unit-tests was skipped until nodejs mock-fs problems resolution #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xed. Some part of unit-tests was skipped until nodejs mock-fs problems resolution
polomsky
previously requested changes
Mar 7, 2024
There was a problem hiding this comment.
I believe that skip should be conditional, for Node version 20.5 and more.
Have you tried to use a different mock system? Somebody used memfs (as shown here tschaub/mock-fs#384)
Sure, I've tried. Memfs works even worse. With mock-fs I was able to make work at least some of the tests. In addition, I don't think that these particular tests are so important to spend too much effort trying to fix them. Evgen also agrees with me. |
JeKachan
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.