Fix build failure in newer node-gyp versions

nodejs/node-gyp#1164 interprets additional node-gyp build parameters as
target names, which breaks the current way CL configs are passed to
msbuild in install.js.

Move the detection logic into configuration phase and pass CL configs as
gyp variables.

Fixes nodejs#321, fixes nodejs#377

binding.gyp

@@ -39,6 +39,12 @@
         "libraries": [
           "<(lldb_lib_dir)/<(lldb_lib)",
         ],
+        "msbuild_settings": {
+            "ClCompile": {
+                "CLToolPath": "<(cl_tool_path)",
+                "CLToolExe": "<(cl_tool_exe)",
+            },
+        },
       }],
       [ "coverage == 'true'", {
         "cflags": [ "--coverage" ],

package.json

@@ -11,7 +11,7 @@
   },
   "scripts": {
     "preinstall": "node scripts/configure.js",
-    "install": "node scripts/install.js",
+    "install": "node-gyp rebuild",
     "postinstall": "node scripts/cleanup.js",
     "test-plugin": "tape test/plugin/*-test.js",
     "test-addon": "tape test/addon/*-test.js",

scripts/configure.js

@@ -78,6 +78,14 @@ function configureInstallation(osName, buildDir) {
     installation = require('./windows').getLldbInstallation();
     config.variables['lldb_lib_dir%'] = installation.libDir;
     config.variables['lldb_lib%'] = installation.libName;
+    const clangExe = 'clang-cl.exe';
+    const clangDir = lldb.findWindowsExeDir(clangExe);
+    if (!clangDir) {
+      console.log(`Could not find ${clangExe}`);
+      process.exit(1);
+    }
+    config.variables['cl_tool_path%'] = clangDir;
+    config.variables['cl_tool_exe%'] = clangExe;
   } else {
     console.log(`Unsupported OS: ${osName}`);
     process.exit(1);