Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move simplified Chinese translations to correct directory #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mygod
Copy link

@Mygod Mygod commented Jul 13, 2018

No description provided.

@dschuermann
Copy link
Member

Hey thanks for the contribution.
Can you explain the difference between zh and zh-CN?
The translations are managed on Transifex, so if we want to change that, we must do it here: https://www.transifex.com/privacyapps/donations/languages/

@Mygod
Copy link
Author

Mygod commented Jul 13, 2018

According to this, putting translations there should be fine as well if this was a client app. But complications arises when developers use this library with resConfigs to trim out unwanted resources. All string resources are provided as zh-rCN in support libraries. Luckily in recent versions, Android allows users to specify secondary languages. I believe everything should be fine as long as you use zh-rCN just like AOSP does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants