Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Board hotkeys now work when board is not selected #290

Merged
merged 9 commits into from
Apr 30, 2024

Conversation

Thomas-Gallant
Copy link
Contributor

@Thomas-Gallant Thomas-Gallant commented Apr 27, 2024

Changelog:

  • pause, undo, and toggle notes hotkeys now work when board is not selected (As long as board has been selected previously)
  • ignoring react-native-web typescript 'error', react-native-web does not have supported Typescript types: https://github.com/necolas/react-native-web/issues/1684
    Additional work will need to be done to get hotkeys working on initial puzzle load.

Checklist for completing pull request:

  • Test functionality on Mobile, Web, and Desktop
  • Verify that any tests for new functionality are created and functional.
  • If needed, update the Readme

Copy link

github-actions bot commented Apr 27, 2024

🚀 Expo preview is ready!

  • Project → sudokuru
  • Platforms → android, ios
  • Scheme → sudokuru
  • Runtime Version → 0.0.0
  • More info

Learn more about 𝝠 Expo Github Action

Copy link

github-actions bot commented Apr 27, 2024

Test Results

86 tests  ±0   86 ✅ ±0   8m 48s ⏱️ +7s
 5 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 63813ea. ± Comparison against base commit 07458f2.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.13%. Comparing base (07458f2) to head (63813ea).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   89.09%   89.13%   +0.03%     
==========================================
  Files          53       53              
  Lines        6411     6433      +22     
  Branches      267      277      +10     
==========================================
+ Hits         5712     5734      +22     
  Misses        685      685              
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Apr 27, 2024

Pull Request Test Coverage Report for Build 8870418295

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 89.301%

Files with Coverage Reduction New Missed Lines %
app/Components/Sudoku Board/SudokuBoard.tsx 3 95.19%
Totals Coverage Status
Change from base Build 8746532477: 0.03%
Covered Lines: 5816
Relevant Lines: 6433

💛 - Coveralls

Copy link

Preview Website for PR:
https://d6ab0eed.sudokuru-dev.pages.dev

@Thomas-Gallant Thomas-Gallant merged commit d9d4000 into main Apr 30, 2024
14 checks passed
@Thomas-Gallant Thomas-Gallant deleted the hotkeyEnhancements branch April 30, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants