Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating prettier and adding eslint #283

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Conversation

Thomas-Gallant
Copy link
Contributor

@Thomas-Gallant Thomas-Gallant commented Mar 17, 2024

Changelog:

Resolving the following eslint errors:
image
image

Checklist for completing pull request:

  • Test functionality on Mobile, Web, and Desktop
  • Verify that any tests for new functionality are created and functional.
  • If needed, update the Readme

Copy link

github-actions bot commented Mar 17, 2024

🚀 Expo preview is ready!

  • Project → sudokuru
  • Platforms → android, ios
  • Scheme → sudokuru
  • Runtime Version → 0.0.0
  • More info

Learn more about 𝝠 Expo Github Action

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 74.74747% with 25 lines in your changes missing coverage. Please review.

Project coverage is 77.04%. Comparing base (5e733a7) to head (6e0108c).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
...omponents/Sudoku Board/Functions/BoardFunctions.ts 25.00% 9 Missing ⚠️
app/Functions/learnedLessons.ts 25.00% 6 Missing ⚠️
app/Components/Home/DrillPanel.tsx 33.33% 4 Missing ⚠️
app/Components/Header.tsx 66.66% 0 Missing and 2 partials ⚠️
app/Pages/Lesson.tsx 77.77% 2 Missing ⚠️
app/Api/Statistics.ts 75.00% 1 Missing ⚠️
app/Functions/AsyncStorage.ts 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   76.86%   77.04%   +0.18%     
==========================================
  Files          53       53              
  Lines        1245     1233      -12     
  Branches      330      328       -2     
==========================================
- Hits          957      950       -7     
+ Misses        278      273       -5     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Mar 17, 2024

Pull Request Test Coverage Report for Build 8314000884

Details

  • 34 of 48 (70.83%) changed or added relevant lines in 13 files are covered.
  • 20 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 74.198%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/Api/Statistics.ts 3 4 75.0%
app/Functions/AsyncStorage.ts 1 2 50.0%
app/Pages/Lesson.tsx 7 9 77.78%
app/Components/Home/DrillPanel.tsx 2 6 33.33%
app/Functions/learnedLessons.ts 2 8 25.0%
Files with Coverage Reduction New Missed Lines %
app/Components/Sudoku Board/Functions/BoardFunctions.ts 6 59.09%
app/Components/Sudoku Board/SudokuBoard.tsx 14 90.4%
Totals Coverage Status
Change from base Build 8223425463: 0.2%
Covered Lines: 746
Relevant Lines: 944

💛 - Coveralls

Copy link

Preview Website for PR:
https://c86d267a.sudokuru-dev.pages.dev

@Thomas-Gallant Thomas-Gallant changed the title Adding es lint Updating prettier and adding eslint Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants