Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lesson Cards #258

Merged
merged 29 commits into from
Oct 15, 2023
Merged

Lesson Cards #258

merged 29 commits into from
Oct 15, 2023

Conversation

Gregory711
Copy link
Contributor

Replaced lesson selection buttons with cards with difficulty labels and conditionally rendered images. Also created the various lesson card images along with bash scripts to convert from one format to another e.g. learned to locked. Finally, refactored logic from drill cards to Cards.ts and reused in lesson cards.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop https://sudokuru-hv8l7rr8c-sudokuru.vercel.app

Device URL
mobile https://sudokuru-hv8l7rr8c-sudokuru.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop https://sudokuru-erj58v6wr-sudokuru.vercel.app

Device URL
mobile https://sudokuru-erj58v6wr-sudokuru.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@github-actions
Copy link

github-actions bot commented Oct 15, 2023

St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟡 All files 75.75 61.61 68.66 76.03
🟢  app 100 100 100 100
🟢   App.tsx 100 100 100 100
🟡  app/Components 69.56 66.66 55.55 69.56
🟡   Header.tsx 80 66.66 66.66 80 51-52
🟡   NavigationSideBar.tsx 61.53 100 50 61.53 20-40
🟡  app/Components/Home 57.98 48.83 64.7 58.11
🟢   Cards.ts 93.33 100 100 93.33 17
🟢   DrillPanel.tsx 97.05 90 100 96.96 136
🟡   HomeButton.tsx 66.66 100 50 66.66 16-17
🔴   LessonPanel.tsx 8 0 0 8.16 61-179
🟢   NavigationButton.tsx 100 70 100 100 29-31
🟡  app/Components/Profile 66.66 100 50 66.66
🟡   ProfileButton.tsx 66.66 100 50 66.66 16-17
🟢  app/Components/Statistics 100 35.29 100 100
🟢   Statistic.tsx 100 50 100 100 16-21
🟢   StatisticsButton.tsx 100 100 100 100
🟢   TotalStatistics.tsx 100 33.33 100 100 30-64
🟢  app/Components/Sudoku 84.75 75.75 91.93 85.78
🟢   EndGameModal.tsx 100 50 100 100 19-35
🟢   SudokuBoard.tsx 82.98 75.23 89.13 84.22 ...50-754,759-761
🟢   sudoku.ts 100 100 100 100
🟢  ...Components/Sudoku 98.4 78.09 100 98.34
🟢   ActionRow.tsx 100 77.77 100 100 24,96-101
🟢   Cell.tsx 97.26 80.82 100 97.1 151-155
🟢   HintSection.tsx 100 76.92 100 100 20,75,106-122
🟢   NumberControl.tsx 100 62.5 100 100 51-72
🟢   PauseButton.tsx 100 50 100 100 8-13
🟢   Puzzle.tsx 100 100 100 100
🟢  app/Components/Sudoku 93.81 80.24 96.77 93.47
🟢   BoardFunctions.ts 91.19 70.31 96 90.8 ...78,281,324,327
🟢   Group.ts 100 100 100 100
🟢   Hint.ts 98.48 70 100 98.36 104
🟢   HintsParsing.ts 100 94.11 100 100 48,80,165,176
🟡   generateGame.ts 77.41 57.14 75 77.41 16-24,38,66
🟡  app/Contexts 71.79 50 27.77 71.79
🟡   InitializeContext.ts 71.05 50 45.45 71.05 ...57,61-62,66-67
🟢   PreferencesContext.ts 100 100 0 100
🔴  app/Functions/Api 40.18 22.22 52.94 40.56
🟢   Drills.ts 100 100 100 100
🔴   Lessons.ts 0 0 0 0 27-271
🔴   Profile.ts 36.84 16.66 66.66 36.84 26-38
🟢   Puzzles.ts 80.64 66.66 80 83.33 202-211
🔴   Statistics.ts 38.88 20 40 38.88 14-34,66-67
🟡  app/Functions/AsyncStorage 54.16 50 60 54.16
🟡   AsyncStorage.ts 54.16 50 60 54.16 ...24,33-39,50,58
🔴  app/Functions/ContextParsing 12 0 0 13.04
🔴   learnedLessons.ts 12 0 0 13.04 ...43-50,62,66-94
🔴  app/Functions/LocalStore/DataStore 37.5 5 50 37.5
🔴   LocalDatabase.ts 37.5 5 50 37.5 11,23-60
🟢  app/Functions/global 100 100 100 100
🟢   WindowDimensions.ts 100 100 100 100
🟢  app/Navigation 100 100 100 100
🟢   DrawerNavigator.tsx 100 100 100 100
🟢  app/Navigation/StackNavigators 88.88 100 66.66 88.88
🟢   DrillStackNavigator.tsx 100 100 100 100
🟢   LandingStackNavigator.tsx 100 100 100 100
🟡   LearnStackNavigator.tsx 66.66 100 0 66.66 9
🟢   PlayStackNavigator.tsx 100 100 100 100
🟡   ProfileStackNavigator.tsx 66.66 100 0 66.66 8
🟢   StatisticsStackNavigator.tsx 100 100 100 100
🟡  app/Pages 50.26 15.11 27.11 53.1
🟢   DrillGame.tsx 100 50 100 100 9
🟡   DrillPage.tsx 69.23 100 20 81.81 54-95
🟢   LandingPage.tsx 100 100 100 100
🔴   LearnPage.tsx 4.54 0 0 5 14-127
🔴   Lesson.tsx 4 0 0 4.16 27-324
🟡   PlayPage.tsx 75 83.33 50 83.33 45,94,129-159
🔴   ProfilePage.tsx 16.66 0 0 16.66 10-29
🟡   StatisticsPage.tsx 68.96 75 33.33 74.07 44-45,54,98-128
🟢   SudokuPage.tsx 100 100 100 100
🟢  app/Styling 97.05 50 100 97.05
🟢   HighlightColors.ts 96.42 50 100 96.42 27
🟢   ThemeColors.tsx 100 100 100 100

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
app/Components/Home/DrillPanel.tsx 97.50% <100.00%> (+1.66%) ⬆️
app/Pages/DrillPage.tsx 75.00% <ø> (+2.77%) ⬆️
app/Components/Home/Cards.ts 95.45% <95.45%> (ø)
app/Pages/LearnPage.tsx 3.70% <0.00%> (ø)
app/Components/Home/LessonPanel.tsx 6.55% <10.81%> (+3.43%) ⬆️

📢 Thoughts on this report? Let us know!.

@github-actions
Copy link

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop https://sudokuru-8pmduzow5-sudokuru.vercel.app

Device URL
mobile https://sudokuru-8pmduzow5-sudokuru.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@Gregory711 Gregory711 merged commit 1e34cc9 into main Oct 15, 2023
@Gregory711 Gregory711 deleted the LessonCards branch October 15, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants