Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle hint mode refactor #252

Merged
merged 7 commits into from
Oct 7, 2023
Merged

Toggle hint mode refactor #252

merged 7 commits into from
Oct 7, 2023

Conversation

Gregory711
Copy link
Contributor

Simplified toggleHintMode function and added comments.

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟡 All files 73.12 59.31 63.78 73.33
🟢  app 100 100 100 100
🟢   App.tsx 100 100 100 100
🟡  app/Components 69.56 58.33 55.55 69.56
🟡   Header.tsx 80 58.33 66.66 80 51-52
🟡   NavigationSideBar.tsx 61.53 100 50 61.53 20-40
🔴  app/Components/Home 43.66 31.03 33.33 43.47
🟢   DrillPanel.tsx 100 100 100 100
🔴   HomeButton.tsx 16.66 100 0 16.66 7-17
🔴   LessonButton.tsx 18.18 0 0 18.18 9-27,44
🔴   LessonPanel.tsx 4 0 0 4.16 19-80
🟢   NavigationButton.tsx 85.71 50 66.66 85.71 40-41
🟡  app/Components/Profile 66.66 100 50 66.66
🟡   ProfileButton.tsx 66.66 100 50 66.66 16-17
🔴  app/Components/Statistics 25 0 20 25
🟡   StatisticsButton.tsx 66.66 100 50 66.66 16-17
🔴   TotalStatistics.tsx 11.11 0 0 11.11 7-45,99
🟢  app/Components/Sudoku 84.82 76.59 92.06 85.85
🟢   EndGameModal.tsx 100 80 100 100 18-19
🟢   SudokuBoard.tsx 82.98 75.23 89.13 84.22 ...50-754,759-761
🟢   sudoku.ts 100 100 100 100
🟢  ...Components/Sudoku 98.4 78.09 100 98.34
🟢   ActionRow.tsx 100 77.77 100 100 24,96-101
🟢   Cell.tsx 97.26 80.82 100 97.1 151-155
🟢   HintSection.tsx 100 76.92 100 100 20,75,106-122
🟢   NumberControl.tsx 100 62.5 100 100 51-72
🟢   PauseButton.tsx 100 50 100 100 8-13
🟢   Puzzle.tsx 100 100 100 100
🟢  app/Components/Sudoku 93.81 80.24 96.77 93.47
🟢   BoardFunctions.ts 91.19 70.31 96 90.8 ...78,281,324,327
🟢   Group.ts 100 100 100 100
🟢   Hint.ts 98.48 70 100 98.36 104
🟢   HintsParsing.ts 100 94.11 100 100 48,80,165,176
🟡   generateGame.ts 77.41 57.14 75 77.41 16-24,38,66
🟡  app/Contexts 71.79 50 27.77 71.79
🟡   InitializeContext.ts 71.05 50 45.45 71.05 ...57,61-62,66-67
🟢   PreferencesContext.ts 100 100 0 100
🔴  app/Functions/Api 38.31 16.66 52.94 38.67
🟢   Drills.ts 100 100 100 100
🔴   Lessons.ts 0 0 0 0 27-271
🔴   Profile.ts 31.57 8.33 66.66 31.57 18,26-38
🟢   Puzzles.ts 80.64 58.33 80 83.33 202-211
🔴   Statistics.ts 33.33 10 40 33.33 14-34,55,66-67
🟡  app/Functions/AsyncStorage 54.16 50 60 54.16
🟡   AsyncStorage.ts 54.16 50 60 54.16 ...24,33-39,50,58
🔴  app/Functions/ContextParsing 12 0 0 13.04
🔴   learnedLessons.ts 12 0 0 13.04 ...43-50,62,66-94
🔴  app/Functions/LocalStore/DataStore 37.5 5 50 37.5
🔴   LocalDatabase.ts 37.5 5 50 37.5 11,23-60
🟢  app/Functions/global 100 100 100 100
🟢   WindowDimensions.ts 100 100 100 100
🟢  app/Navigation 100 100 100 100
🟢   DrawerNavigator.tsx 100 100 100 100
🟢  app/Navigation/StackNavigators 83.33 100 50 83.33
🟢   DrillStackNavigator.tsx 100 100 100 100
🟢   LandingStackNavigator.tsx 100 100 100 100
🟡   LearnStackNavigator.tsx 66.66 100 0 66.66 9
🟢   PlayStackNavigator.tsx 100 100 100 100
🟡   ProfileStackNavigator.tsx 66.66 100 0 66.66 8
🟡   StatisticsStackNavigator.tsx 66.66 100 0 66.66 8
🔴  app/Pages 40.72 12.5 19.67 43.33
🟢   DrillGame.tsx 100 50 100 100 9
🟡   DrillPage.tsx 66.66 50 14.28 85.71 61-109
🟢   LandingPage.tsx 100 100 100 100
🔴   LearnPage.tsx 4.54 0 0 5 14-129
🔴   Lesson.tsx 4 0 0 4.16 27-324
🟡   PlayPage.tsx 75 83.33 50 83.33 45,94,129-159
🔴   ProfilePage.tsx 16.66 0 0 16.66 10-29
🔴   StatisticsPage.tsx 3.44 0 0 3.7 15-116
🟢   SudokuPage.tsx 100 100 100 100
🟢  app/Styling 97.05 50 100 97.05
🟢   HighlightColors.ts 96.42 50 100 96.42 27
🟢   ThemeColors.tsx 100 100 100 100

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6367406527

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 30 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 68.593%

Files with Coverage Reduction New Missed Lines %
app/Components/Sudoku Board/SudokuBoard.tsx 30 81.68%
Totals Coverage Status
Change from base Build 6346566093: -0.1%
Covered Lines: 1103
Relevant Lines: 1504

💛 - Coveralls

@codecov-commenter
Copy link

Codecov Report

Merging #252 (c916609) into main (5991784) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   69.93%   69.80%   -0.14%     
==========================================
  Files          54       54              
  Lines        1966     1954      -12     
  Branches      571      563       -8     
==========================================
- Hits         1375     1364      -11     
+ Misses        584      583       -1     
  Partials        7        7              
Files Coverage Δ
app/Components/Sudoku Board/SudokuBoard.tsx 86.06% <100.00%> (-0.16%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5991784...c916609. Read the comment docs.

@Gregory711 Gregory711 merged commit 61ce510 into main Oct 7, 2023
11 checks passed
@Gregory711 Gregory711 deleted the toggleHintModeRefactor branch October 7, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants