Add assertions for subtitle time duration in milliseconds #9047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test now includes checks for the start and end times in milliseconds to ensure accuracy of subtitle timing. The commented out asserts are intended to handle timecode formatting, which provides a context for further investigation on their failure in specific environments like AppVeyor. Signed-off-by: Ivandro Jao <[email protected]>
This change adds an assertion to verify that the current thread culture is set to "en-US" during the test execution. Ensuring the correct culture is crucial for precise interpretation of any locale-specific operations within the test. This helps maintain consistency and predictability across different environments. Signed-off-by: Ivandro Jao <[email protected]>
Previously, the test used Assert.Equals, which is not a valid method for comparing values in this context. This change corrects the assertion to Assert.AreEqual, ensuring it correctly checks the CurrentCulture Name property. This fix ensures proper test validation and consistency in the test assertions. Signed-off-by: Ivandro Jao <[email protected]>
Refactor the `MakeSubtitle` method for cleaner return logic and improve the `DetectSeparator` function for more accurate separator detection. Adjust the test in `UnknownFormatImporterCsvTest.cs` to correct the expected duration for subtitle end time. Signed-off-by: Ivandro Jao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating appveyor issue with TestUnknownCsv3