feat: wait for compute plan & tasks to finish before using output assets #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhem-barthes
force-pushed
the
fix/wait-end-for-downloading-output
branch
from
56a361f
to
ddd373a
Compare
|
Why is it a fix ? and why are you changing this behaviour ? It looks like a feature change to discuss with product 😶 |
SdgJlbl
reviewed
Jul 3, 2023
guilhem-barthes
force-pushed
the
fix/wait-end-for-downloading-output
branch
from
d2ca31f
to
684f108
Compare
|
/e2e |
|
End to end tests: ✔️ SUCCESS |
guilhem-barthes
changed the title
ThibaultFy
reviewed
Jul 28, 2023
CHANGELOG.md
Outdated
| @@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ### Added | |||
|
|
|||
| - `wait_task` and `wait_compute_plan` to block execution until execution is over ([#368](https://github.com/Substra/substra/pull/368)) | |||
| - `wait_completion` param on `wait_task` and `wait_compute_plan` to block execution until execution is over ([#368](https://github.com/Substra/substra/pull/368)) | |||
There was a problem hiding this comment.
The param is not on wait_task and wait_compute_plan is it ?
CHANGELOG.md
Outdated
Comment on lines
23
to
27
| ### Fixed | ||
|
|
||
| - `list_task_output_assets` and `get_task_output_asset` wait that the compute task is over before getting assets ([#369](https://github.com/Substra/substra/pull/369)) | ||
| - `get_performances` wait that compute plan is over before getting assets ([#369](https://github.com/Substra/substra/pull/369)) | ||
|
|
There was a problem hiding this comment.
Duplicate of the fixed section. And is it really a fix ? Looks like a feature no ?
There was a problem hiding this comment.
@RomainGoussault What is your opinion?
Signed-off-by: Guilhem Barthes <[email protected]>
Signed-off-by: Guilhem Barthes <[email protected]>
Signed-off-by: Guilhem Barthes <[email protected]>
Signed-off-by: Guilhem Barthes <[email protected]>
Signed-off-by: Guilhem Barthes <[email protected]>
Signed-off-by: Guilhem Barthes <[email protected]>
Signed-off-by: Guilhem Barthes <[email protected]>
guilhem-barthes
force-pushed
the
fix/wait-end-for-downloading-output
branch
from
4b3ee3d
to
a03071d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#followed by the number of the issueSummary
Notes
Useful in FL-994
Please check if the PR fulfills these requirements