Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sublimeBidAdapter): modifying bid request contentType #25

Open
wants to merge 4 commits into
base: sublime-adapter-bundle
Choose a base branch
from

Conversation

fgcloutier
Copy link

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

How to test

  • check that

    gulp test --file test/spec/modules/sublimeBidAdapter_spec.js

    is green;

  • execute:

    gulp serve-fast --modules=appnexusBidAdapter,sublimeBidAdapter`

This will compile prebid.js, launch a test server and run the tests.

Other information

https://sublimeskinz.atlassian.net/browse/DL-1476

@fgcloutier fgcloutier self-assigned this Sep 10, 2020
const DEFAULT_BID_HOST = 'pbjs.sskzlabs.com';
const DEFAULT_CALLBACK_NAME = 'sublime_prebid_callback';
const DEFAULT_CURRENCY = 'EUR';
const DEFAULT_PROTOCOL = 'https';
const DEFAULT_SAC_HOST = 'sac.ayads.co'
const DEFAULT_TTL = 600;
const SUBLIME_ANTENNA = 'antenna.ayads.co';
const SUBLIME_VERSION = '0.5.2-bundle';
const SUBLIME_VERSION = '0.6.1-bundle';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On ne serait pas plutôt sur une version 0.7.0 ? (pour être raccord avec le nouvel adapter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants