Makefile linter

[giampaolo]

I recently worked on this: https://github.com/giampaolo/SublimeLinter-contrib-makefile. The motivation which led me to it is because the only Makefile linter I found is https://github.com/mrtazz/checkmake, which provides a limited set of rules:

$ go run github.com/mrtazz/checkmake/cmd/checkmake@latest --list-rules
                                                      
        NAME                   DESCRIPTION            
                                                      
  maxbodylength       Target bodies should be kept    
                      simple and short.               
  minphony            Minimum required phony targets  
                      must be present                 
  phonydeclared       Every target without a body     
                      needs to be marked PHONY        
  timestampexpanded   timestamp variables should be   
                      simply expanded   

I use Makefiles in all of my projects, not to compile stuff, but to run repetitive tasks. I wanted to be able to identify (amongst other things) undefined variable names, undefined target names, and use of spaces instead of tabs. As such I decided to write my own plugin and came up with this.

In the future I may decide to turn this into a generic CLI tool, but for now this is implemented as a plugin which can only be used with Sublime Text + SublimeLinter.

[kaste]

That doesn't look like a bad idea but you should not query self.view = sublime.active_window().active_view() because the linter might run lazy. The linter instance knows about the view it's linting so return Parser(self.view).run(), t.i. injecting the view, should be more reliable.

You need to make a release or push a semver tag (like 0.0.1 or so) though before I can merge.

[giampaolo]

That doesn't look like a bad idea but you should not query self.view = sublime.active_window().active_view() because the linter might run lazy. The linter instance knows about the view it's linting so return Parser(self.view).run(), t.i. injecting the view, should be more reliable.

You need to make a release or push a semver tag (like 0.0.1 or so) though before I can merge.

Thanks for the suggestion about view. I just pushed a git tag named 0.1.0.

[kaste]

Not the standard adapter, well done. Looks like you know what you're doing. 👍

[giampaolo]

Thanks for your time and the merge! :)