Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fillWidth option for wrap content behavior #83

Closed
wants to merge 5 commits into from
Closed

Add fillWidth option for wrap content behavior #83

wants to merge 5 commits into from

Conversation

nvbln
Copy link

@nvbln nvbln commented May 8, 2019

Defaults to true to make it a non-breaking change.
Fixes #75.

PR made on behalf of Wilko Manger

@nvbln
Add fillWidth option for wrap content behavior
c22ec19 
Defaults to true to make it a non-breaking change.
Fixes Sub6Resources#75.
@Sub6Resources Sub6Resources self-requested a review May 8, 2019 19:58
@Sub6Resources Sub6Resources self-assigned this May 8, 2019
@Sub6Resources Sub6Resources added bugfix Fixes a bug in the package high-priority labels May 8, 2019
@Sub6Resources Sub6Resources added this to the Next Version milestone May 14, 2019
Sub6Resources
Sub6Resources requested changes May 18, 2019
View reviewed changes
lib/html_parser.dart Outdated Show resolved Hide resolved
@XZYsunny XZYsunny mentioned this pull request Jul 8, 2019
Closed
@Sub6Resources Sub6Resources modified the milestones: Next Version, 0.11.0 Jul 17, 2019
Wilko Manger and others added 2 commits July 18, 2019 17:05
@amake amake mentioned this pull request Aug 26, 2019
Merged
@Sub6Resources
Copy link
Owner

I really appreciate the pull request, but I believe #148 should provide similar functionality and shrinkToFit is a convention Flutter developers are used to seeing. Closing this for now. Feel free to comment if you disagree.

@wilkomanger
Copy link

Only thing that is missing from #148 is the horizontalAlignment parameter. Should I create a new PR for that?

@wilkomanger
Copy link

Also, I'd suggest that shrinkToFit be renamed to shrinkWrap for even a more Flutter-like name.

@Sub6Resources
Copy link
Owner

Yeah, go ahead and open a new pull request for that. I'll think about using shrinkWrap, but you're right, that probably is the more common convention.

@fahami fahami mentioned this pull request Oct 12, 2022
Closed
@Equirinya Equirinya mentioned this pull request Aug 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sub6Resources Sub6Resources Sub6Resources approved these changes

Assignees

@Sub6Resources Sub6Resources

Labels
bugfix Fixes a bug in the package high-priority
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

Always left aligned
3 participants
@nvbln @Sub6Resources @wilkomanger