Added custom textstyle and edgeinsets callback #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sub6Resources
requested changes
Mar 12, 2019
There was a problem hiding this comment.
Thanks, this is a great pull request. Do you think you could also add support for the HtmlOldParser? If not, let me know and I can do it myself. I don't have a lot of spare time, though, so it will probably take a couple weeks to merge this if I do it myself. 😉
|
@Sub6Resources If I see this correctly, the |
|
@elsesiy You're right. I didn't think of that before. I'll work on merging this. |
Sub6Resources
approved these changes
Mar 18, 2019
|
@Sub6Resources Any update on this? Thanks! |
|
This has been released in version 0.9.7. Thank you for your patience. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first of all: really great work, I really appreciate it!
For a recent project we were missing the possibility to change the textstyle and the margins of specific elements when we use the "useRichText" flag.
I implemented CustomEdgeInsets and CustomTextStyle callbacks in the style of your CustomRender to provide custom textstyles to the element and margins to the containing BlockText object.
The CustomTextStyle callback supplies the node and the childStyle, so we can use the childStyle to modify it (e.g. change color depending of a css class) or simply create a completely different style.