Skip to content

Commit

Permalink
removed aria from remove element icon. (shentao#1071)
Browse files Browse the repository at this point in the history
The close icon on the multiselect has conflicting attributes: aria-hidden="true" and tabindex="1". this means that it is hidden from screen readers, but still focusable. https://act-rules.github.io/rules/6cfa84 see Failed Example 4: Focusable content through tabindex.

<p tabindex="0" aria-hidden="true">Some text</p>
  • Loading branch information
valantonini authored and shentao committed Sep 25, 2019
1 parent 4763ac0 commit 52f9593
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Multiselect.vue
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<slot name="tag" :option="option" :search="search" :remove="removeElement">
<span class="multiselect__tag" :key="index">
<span v-text="getOptionLabel(option)"></span>
<i aria-hidden="true" tabindex="1" @keypress.enter.prevent="removeElement(option)" @mousedown.prevent="removeElement(option)" class="multiselect__tag-icon"></i>
<i tabindex="1" @keypress.enter.prevent="removeElement(option)" @mousedown.prevent="removeElement(option)" class="multiselect__tag-icon"></i>
</span>
</slot>
</template>
Expand Down

0 comments on commit 52f9593

Please sign in to comment.