feat: make unit test pass

Signed-off-by: suzhou <[email protected]>
SuZhou-Joe · May 10, 2023 · ca37317 · ca37317
1 parent 83638f0
commit ca37317
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 64 deletions.
diff --git a/...ic/components/UnsavedChangesBottomBar/__snapshots__/UnsavedChangesBottomBar.test.tsx.snap b/...ic/components/UnsavedChangesBottomBar/__snapshots__/UnsavedChangesBottomBar.test.tsx.snap
@@ -17,12 +17,6 @@ HTMLCollection [
       <div
         class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--alignItemsCenter euiFlexGroup--directionRow euiFlexGroup--responsive"
       >
-        <div
-          class="euiFlexItem"
-        >
-          0
-           unsaved changes.
-        </div>
         <div
           class="euiFlexItem euiFlexItem--flexGrowZero"
         >

diff --git a/public/pages/Indices/containers/IndicesActions/IndicesActions.test.tsx b/public/pages/Indices/containers/IndicesActions/IndicesActions.test.tsx
@@ -48,9 +48,6 @@ describe("<IndicesActions /> spec", () => {
       onShrink: function (): void {
         throw new Error("Function not implemented.");
       },
-      getIndices: function (): Promise<void> {
-        throw new Error("Function not implemented.");
-      },
     });
 
     await waitFor(() => {
@@ -98,9 +95,6 @@ describe("<IndicesActions /> spec", () => {
       onShrink: function (): void {
         throw new Error("Function not implemented.");
       },
-      getIndices: function (): Promise<void> {
-        throw new Error("Function not implemented.");
-      },
     });
 
     await waitFor(() => {
@@ -112,7 +106,7 @@ describe("<IndicesActions /> spec", () => {
     userEvent.click(getByTestId("Open Confirm button"));
 
     await waitFor(() => {
-      expect(browserServicesMock.commonService.apiCaller).toHaveBeenCalledTimes(1);
+      expect(browserServicesMock.commonService.apiCaller).toHaveBeenCalledTimes(2);
       expect(browserServicesMock.commonService.apiCaller).toHaveBeenCalledWith({
         endpoint: "transport.request",
         data: {
@@ -155,9 +149,6 @@ describe("<IndicesActions /> spec", () => {
       onShrink: function (): void {
         throw new Error("Function not implemented.");
       },
-      getIndices: function (): Promise<void> {
-        throw new Error("Function not implemented.");
-      },
     });
 
     await waitFor(() => {
@@ -230,9 +221,6 @@ describe("<IndicesActions /> spec", () => {
       onShrink: function (): void {
         throw new Error("Function not implemented.");
       },
-      getIndices: function (): Promise<void> {
-        throw new Error("Function not implemented.");
-      },
     });
 
     await waitFor(() => {
@@ -271,9 +259,6 @@ describe("<IndicesActions /> spec", () => {
     const history = createMemoryHistory();
 
     const { container, getByTestId } = renderWithRouter({
-      getIndices(): Promise<void> {
-        return Promise.resolve(undefined);
-      },
       history: history,
       location: history.location,
       onClose(): void {},
@@ -314,9 +299,6 @@ describe("<IndicesActions /> spec", () => {
     const history = createMemoryHistory();
 
     const { container, getByTestId } = renderWithRouter({
-      getIndices(): Promise<void> {
-        return Promise.resolve(undefined);
-      },
       history: history,
       location: history.location,
       onClose(): void {},
@@ -370,9 +352,6 @@ describe("<IndicesActions /> spec", () => {
     const history = createMemoryHistory();
 
     const { container, getByTestId } = renderWithRouter({
-      getIndices(): Promise<void> {
-        return Promise.resolve(undefined);
-      },
       history: history,
       location: history.location,
       onClose(): void {},
@@ -411,9 +390,6 @@ describe("<IndicesActions /> spec", () => {
     const history = createMemoryHistory();
 
     const { getByTestId } = renderWithRouter({
-      getIndices(): Promise<void> {
-        return Promise.resolve(undefined);
-      },
       history: history,
       location: history.location,
       onClose(): void {},
@@ -450,9 +426,6 @@ describe("<IndicesActions /> spec", () => {
     const history = createMemoryHistory();
 
     const { getByTestId } = renderWithRouter({
-      getIndices(): Promise<void> {
-        return Promise.resolve(undefined);
-      },
       history: history,
       location: history.location,
       onClose(): void {},
@@ -499,9 +472,6 @@ describe("<IndicesActions /> spec", () => {
       onShrink: function (): void {
         throw new Error("Function not implemented.");
       },
-      getIndices: function (): Promise<void> {
-        throw new Error("Function not implemented.");
-      },
     });
 
     await waitFor(() => {
@@ -556,9 +526,6 @@ describe("<IndicesActions /> spec", () => {
       onShrink: function (): void {
         throw new Error("Function not implemented.");
       },
-      getIndices: function (): Promise<void> {
-        throw new Error("Function not implemented.");
-      },
     });
 
     await waitFor(() => {
@@ -597,9 +564,6 @@ describe("<IndicesActions /> spec", () => {
       onShrink: function (): void {
         throw new Error("Function not implemented.");
       },
-      getIndices: function (): Promise<void> {
-        throw new Error("Function not implemented.");
-      },
     });
 
     await waitFor(() => {

diff --git a/public/pages/Indices/containers/IndicesActions/index.tsx b/public/pages/Indices/containers/IndicesActions/index.tsx
@@ -26,7 +26,6 @@ export interface IndicesActionsProps extends Pick<RouteComponentProps, "history"
   onDelete: () => void;
   onClose: () => void;
   onShrink: () => void;
-  getIndices: () => Promise<void>;
 }
 
 export default function IndicesActions(props: IndicesActionsProps) {

diff --git a/public/utils/helpers.ts b/public/utils/helpers.ts
@@ -12,8 +12,6 @@ import { BrowserServices } from "../models/interfaces";
 import { IndexOpBlocksType } from "./constants";
 import { CatIndex, DataStream } from "../../server/models/interfaces";
 import { IAlias } from "../pages/Aliases/interface";
-import { ClusterInfo } from "../models/interfaces";
-import { CommonService } from "../services";
 
 export function getErrorMessage(err: any, defaultMessage: string) {
   if (err && err.message) return err.message;
@@ -64,7 +62,7 @@ export const getClusterInfo = (props: { commonService: CommonService }): Promise
     .then((res) => {
       if (res && res.ok) {
         return {
-          cluster_name: res.response.cluster_name,
+          cluster_name: res?.response?.cluster_name,
         };
       }
 
@@ -169,20 +167,3 @@ export async function filterBlockedItems<T>(
   });
   return result;
 }
-export const getClusterInfo = (props: { commonService: CommonService }): Promise<ClusterInfo> => {
-  return props.commonService
-    .apiCaller<{
-      cluster_name: string;
-    }>({
-      endpoint: "cluster.health",
-    })
-    .then((res) => {
-      if (res && res.ok) {
-        return {
-          cluster_name: res.response.cluster_name,
-        };
-      }
-
-      return {};
-    });
-};