Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workspace icon in workspace creator #19

Conversation

wanglam
Copy link

@wanglam wanglam commented Sep 2, 2024

Description

This PR is for adding workspace icon in workspace creator.

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@SuZhou-Joe SuZhou-Joe merged commit 9bd3052 into SuZhou-Joe:feature/add-workspace-icon Sep 2, 2024
1 of 2 checks passed
SuZhou-Joe added a commit that referenced this pull request Sep 4, 2024
… home page. (opensearch-project#7823)

* feat: show workspace picker content in left nav

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: bootstrap error

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test error

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: finish picker content

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: finish picker content

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: only register index patterns to settings and setup when workspace is disabled

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: put discover 2.0 behind discover

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add coverage

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: improve test coverage

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: merge conflict

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code based on comment

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code based on comment

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize filter code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add new icon to left navigation and workspace picker menu

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: change use case card in home

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize alignment

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR opensearch-project#7823 created/updated

* feat: alignment optimize

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: use new icons in workspace picker

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize color

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test error

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: increase test coverage

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless code

Signed-off-by: SuZhou-Joe <[email protected]>

* Add workspace icon in workspace creator (#19)

Signed-off-by: Lin Wang <[email protected]>

* fix: fatal error when visibleUseCases is empty

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Lin Wang <[email protected]>
(cherry picked from commit 1974ca1)
SuZhou-Joe added a commit that referenced this pull request Sep 5, 2024
… home page. (opensearch-project#7823)

* feat: show workspace picker content in left nav

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: bootstrap error

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test error

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: finish picker content

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: finish picker content

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: only register index patterns to settings and setup when workspace is disabled

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: put discover 2.0 behind discover

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add coverage

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: improve test coverage

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: merge conflict

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code based on comment

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code based on comment

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize filter code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add new icon to left navigation and workspace picker menu

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: change use case card in home

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize alignment

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR opensearch-project#7823 created/updated

* feat: alignment optimize

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: use new icons in workspace picker

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize color

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test error

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: increase test coverage

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless code

Signed-off-by: SuZhou-Joe <[email protected]>

* Add workspace icon in workspace creator (#19)

Signed-off-by: Lin Wang <[email protected]>

* fix: fatal error when visibleUseCases is empty

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Lin Wang <[email protected]>
SuZhou-Joe pushed a commit that referenced this pull request Sep 10, 2024
… home page. (opensearch-project#7823) (opensearch-project#7994) (opensearch-project#7995)

* feat: show workspace picker content in left nav



* fix: bootstrap error



* fix: unit test error



* feat: finish picker content



* feat: finish picker content



* feat: only register index patterns to settings and setup when workspace is disabled



* fix: unit test



* feat: put discover 2.0 behind discover



* feat: add coverage



* feat: improve test coverage



* feat: merge conflict



* feat: optimize code based on comment



* feat: optimize code based on comment



* feat: optimize filter code



* feat: update



* feat: add new icon to left navigation and workspace picker menu



* feat: change use case card in home



* feat: optimize alignment



* Changeset file for PR opensearch-project#7823 created/updated

* feat: alignment optimize



* feat: use new icons in workspace picker



* feat: optimize color



* fix: unit test error



* fix: unit test



* fix: unit test



* feat: increase test coverage



* feat: remove useless code



* Add workspace icon in workspace creator (#19)



* fix: fatal error when visibleUseCases is empty



---------





(cherry picked from commit 1974ca1)
(cherry picked from commit cbdb0fd)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Lin Wang <[email protected]>
SuZhou-Joe pushed a commit that referenced this pull request Oct 3, 2024
… home page. (opensearch-project#7823) (opensearch-project#7994) (opensearch-project#7995) (opensearch-project#8038)

* feat: show workspace picker content in left nav

* fix: bootstrap error

* fix: unit test error

* feat: finish picker content

* feat: finish picker content

* feat: only register index patterns to settings and setup when workspace is disabled

* fix: unit test

* feat: put discover 2.0 behind discover

* feat: add coverage

* feat: improve test coverage

* feat: merge conflict

* feat: optimize code based on comment

* feat: optimize code based on comment

* feat: optimize filter code

* feat: update

* feat: add new icon to left navigation and workspace picker menu

* feat: change use case card in home

* feat: optimize alignment

* Changeset file for PR opensearch-project#7823 created/updated

* feat: alignment optimize

* feat: use new icons in workspace picker

* feat: optimize color

* fix: unit test error

* fix: unit test

* fix: unit test

* feat: increase test coverage

* feat: remove useless code

* Add workspace icon in workspace creator (#19)

* fix: fatal error when visibleUseCases is empty

---------

(cherry picked from commit 1974ca1)
(cherry picked from commit cbdb0fd)







(cherry picked from commit 4c64d81)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Lin Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants