[navigation] Remove nav group for dev tools (opensearch-project#8218) (…

…opensearch-project#8238) * remove nav group for dev tools * Changeset file for PR opensearch-project#8218 created/updated --------- (cherry picked from commit 6f9672b) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe · Oct 3, 2024 · 9dcbfbf · 9dcbfbf
1 parent 981f500
commit 9dcbfbf
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 9 deletions.
diff --git a/changelogs/fragments/8218.yml b/changelogs/fragments/8218.yml
@@ -0,0 +1,2 @@
+fix:
+- Remove nav group for dev tools ([#8218](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8218))
diff --git a/src/plugins/dev_tools/public/dev_tools_icon.test.tsx b/src/plugins/dev_tools/public/dev_tools_icon.test.tsx
@@ -7,17 +7,13 @@ import React from 'react';
 import { fireEvent, render } from '@testing-library/react';
 import { DevToolsIcon } from './dev_tools_icon';
 import { coreMock } from '../../../core/public/mocks';
-import { DEFAULT_NAV_GROUPS } from '../../../core/public';
 
 describe('<DevToolsIcon />', () => {
   it('should call chrome.navGroup.setCurrentNavGroup and application.navigateToApp methods from core service when click', () => {
     const coreStartMock = coreMock.createStart();
     const { container } = render(<DevToolsIcon core={coreStartMock} appId="foo" />);
     const component = container.children[0];
     fireEvent.click(component);
-    expect(coreStartMock.chrome.navGroup.setCurrentNavGroup).toBeCalledWith(
-      DEFAULT_NAV_GROUPS.dataAdministration.id
-    );
     expect(coreStartMock.application.navigateToApp).toBeCalledWith('foo');
   });
 });
diff --git a/src/plugins/dev_tools/public/dev_tools_icon.tsx b/src/plugins/dev_tools/public/dev_tools_icon.tsx
@@ -6,18 +6,13 @@
 import React from 'react';
 import { EuiButtonIcon } from '@elastic/eui';
 import { CoreStart } from 'opensearch-dashboards/public';
-import { DEFAULT_NAV_GROUPS } from '../../../core/public';
 
 export function DevToolsIcon({ core, appId }: { core: CoreStart; appId: string }) {
   return (
     <EuiButtonIcon
       aria-label="go-to-dev-tools"
       iconType="consoleApp"
       onClick={() => {
-        /**
-         * This is a workaround in 2.16, once devTools being refactor to a drawer, we can remove the setCurrentNavGroup line.
-         */
-        core.chrome.navGroup.setCurrentNavGroup(DEFAULT_NAV_GROUPS.dataAdministration.id);
         core.application.navigateToApp(appId);
       }}
     />
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		fix:
		- Remove nav group for dev tools ([#8218](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8218))