Skip to content

Commit

Permalink
Fix build error and part of test error (opensearch-project#42)
Browse files Browse the repository at this point in the history
* fix: fix build error and some ut

Signed-off-by: tygao <[email protected]>

* chore: remove saved object client test diff

Signed-off-by: tygao <[email protected]>

---------

Signed-off-by: tygao <[email protected]>
  • Loading branch information
raintygao authored and SuZhou-Joe committed Aug 31, 2023
1 parent 02fae17 commit 78b0efa
Show file tree
Hide file tree
Showing 13 changed files with 4,659 additions and 4,273 deletions.
7,668 changes: 3,892 additions & 3,776 deletions src/core/public/chrome/ui/header/__snapshots__/collapsible_nav.test.tsx.snap

Large diffs are not rendered by default.

1,199 changes: 710 additions & 489 deletions src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/core/public/chrome/ui/header/collapsible_nav.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ describe('CollapsibleNav', () => {
recentlyAccessed$={new BehaviorSubject(recentNavLinks)}
/>
);
expectShownNavLinksCount(component, 3);
expectShownNavLinksCount(component, 0);
clickGroup(component, 'opensearchDashboards');
clickGroup(component, 'recentlyViewed');
expectShownNavLinksCount(component, 1);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ const createSetupContractMock = () => {
getOpenSearchDashboardsBuildNumber: jest.fn(),
getBranding: jest.fn(),
getSurvey: jest.fn(),
getWorkspaceBasePath: jest.fn(),
};
setupContract.getCspConfig.mockReturnValue({ warnLegacyBrowsers: true });
setupContract.getOpenSearchDashboardsVersion.mockReturnValue('opensearchDashboardsVersion');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ describe('getSortedObjectsForExport()', () => {
index-pattern,
search,
],
workspaces: undefined,
},
],
],
Expand Down Expand Up @@ -218,6 +219,7 @@ describe('getSortedObjectsForExport()', () => {
index-pattern,
search,
],
workspaces: undefined,
},
],
],
Expand Down Expand Up @@ -368,6 +370,7 @@ describe('getSortedObjectsForExport()', () => {
index-pattern,
search,
],
workspaces: undefined,
},
],
],
Expand Down Expand Up @@ -459,6 +462,7 @@ describe('getSortedObjectsForExport()', () => {
index-pattern,
search,
],
workspaces: undefined,
},
],
],
Expand Down Expand Up @@ -666,6 +670,7 @@ describe('getSortedObjectsForExport()', () => {
],
Object {
namespace: undefined,
workspaces: undefined,
},
],
],
Expand Down Expand Up @@ -784,6 +789,7 @@ describe('getSortedObjectsForExport()', () => {
],
Object {
namespace: undefined,
workspaces: undefined,
},
],
Array [
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ describe('IndexMigrator', () => {
references: '7997cf5a56cc02bdc9c93361bde732b0',
type: '2f4316de49999235636386fe51dc06c1',
updated_at: '00da57df13e94e9d98437d13ace4bfe0',
workspaces: '2f4316de49999235636386fe51dc06c1',
},
},
properties: {
Expand All @@ -92,6 +93,9 @@ describe('IndexMigrator', () => {
originId: { type: 'keyword' },
type: { type: 'keyword' },
updated_at: { type: 'date' },
workspaces: {
type: 'keyword',
},
references: {
type: 'nested',
properties: {
Expand Down Expand Up @@ -199,6 +203,7 @@ describe('IndexMigrator', () => {
references: '7997cf5a56cc02bdc9c93361bde732b0',
type: '2f4316de49999235636386fe51dc06c1',
updated_at: '00da57df13e94e9d98437d13ace4bfe0',
workspaces: '2f4316de49999235636386fe51dc06c1',
},
},
properties: {
Expand All @@ -210,6 +215,9 @@ describe('IndexMigrator', () => {
originId: { type: 'keyword' },
type: { type: 'keyword' },
updated_at: { type: 'date' },
workspaces: {
type: 'keyword',
},
references: {
type: 'nested',
properties: {
Expand Down Expand Up @@ -260,6 +268,7 @@ describe('IndexMigrator', () => {
references: '7997cf5a56cc02bdc9c93361bde732b0',
type: '2f4316de49999235636386fe51dc06c1',
updated_at: '00da57df13e94e9d98437d13ace4bfe0',
workspaces: '2f4316de49999235636386fe51dc06c1',
},
},
properties: {
Expand All @@ -271,6 +280,9 @@ describe('IndexMigrator', () => {
originId: { type: 'keyword' },
type: { type: 'keyword' },
updated_at: { type: 'date' },
workspaces: {
type: 'keyword',
},
references: {
type: 'nested',
properties: {
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 78b0efa

Please sign in to comment.