Handle file:// URLs in exclusion policy
#1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not an ideal solution, as we should not be sending URLs to the linter in the first place. But as fixing that is a much broader issue, we'll have to settle for a hack in the meantime. Fixes #1204 Signed-off-by: Anders Eknert <[email protected]>
charlieegan3
force-pushed
the
handle-url-exclusion
branch
from
f1852bc to
fa35117
Compare
anderseknert
force-pushed
the
handle-url-exclusion
branch
from
fa35117 to
7ac30f0
Compare
charlieegan3
approved these changes
Oct 16, 2024
charlieegan3
pushed a commit
to charlieegan3/regal
that referenced
this pull request
Jan 6, 2025
This is not an ideal solution, as we should not be sending URLs to the linter in the first place. But as fixing that is a much broader issue, we'll have to settle for a hack in the meantime. Fixes StyraInc#1204 Signed-off-by: Anders Eknert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not an ideal solution, as we should not be sending URLs to the linter in the first place. But as fixing that is a much broader issue, we'll have to settle for a hack in the meantime.
Fixes #1204