Update to Kafka 2.13-2.7.0 #18
Conversation
mdanielolsson
requested review from
anderseknert,
lukasz-kaminski,
bcarlsson,
maglun2 and
gustav-lindstedt
| if (superUsers.contains(session.principal.toString)) { | ||
| logger.trace(s"User ${session.principal} is super user") | ||
| return true | ||
| override def authorize(requestContext: AuthorizableRequestContext, actions: ju.List[Action]): ju.List[AuthorizationResult] = { |
There was a problem hiding this comment.
Could you rename ju to something more descriptive?
There was a problem hiding this comment.
Yeah, not sure if we even need to shorten it. I'll remove and use java.util instead.
| case class Request(input: Input) | ||
| case class CachableRequest(principal: KafkaPrincipal, actions: ju.List[Action], connectionId: InetAddress) | ||
| case class AzRequestContext( |
There was a problem hiding this comment.
Since it's only used in tests, I'd suggest moving it there.
There was a problem hiding this comment.
I moved it to a new file with the tests since it's used in both tests, benchmark and spec.
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
============================================
+ Coverage 46.34% 52.72% +6.38%
- Complexity 14 20 +6
============================================
Files 1 1
Lines 41 55 +14
Branches 9 14 +5
============================================
+ Hits 19 29 +10
- Misses 7 10 +3
- Partials 15 16 +1
Continue to review full report at Codecov.
|
mdanielolsson
force-pushed
the
update_kafka_2.13-2.7.0
branch
from
d03954e to
4a0e144
Compare
|
Nice! 👍 |
Updating Scala to 2.13 and Kafka 2.7.0. This comes with big changes since Kafka has deprecated their old libraries and the new API is preferred.
The input to OPA will change after this change. More details are described in the proposed changelog update.
I'm suggesting this would be a major release.