Skip to content

Commit

Permalink
Frontpage: Fix rss link color, better selector
Browse files Browse the repository at this point in the history 
Also fixed Stylelint quotes issue introduced earlier.
  • Loading branch information
@silverwind
silverwind committed Jul 19, 2016
1 parent 7aa4ae9 commit e590fd0
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions github-dark.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1599,7 +1599,7 @@
.markdown-format h6 .octicon-link, .tabnav-tab.selected,
.leaflet-control-attribution, .leaflet-control-attribution a,
.integrations-breadcrumb-link, a.integrations-breadcrumb-link,
.ace_button {
.ace_button, .link-gray-dark, a.link-gray-dark {

This comment has been minimized.

Sign in to view

Copy link
@un1versal

un1versal Jul 19, 2016 •
edited
Loading

Contributor

in my opinion this is a bad design decision from GitHub.

GitHub Dark, should not emulate/condone their bad decisions.

Links are naturally expected to be blue and when you visited them they are expected to have a visited color,

Ignoring this preconception imo is bad web design (something GitHub often do.). because you cant distinguish what is a link from what is normal text—until you hover it with a mouse—or use another navigation method...

I once read a book titled "Dont Make Me Think: A common sense approach to web usability by Steve Krug
At my earliest convenience I will shoot and email with a link to that book to GitHub Support in a ironic and sarcastic sort of way.
color: #e0e0e0 !important;
}
b, strong, .explain strong {
Expand Down Expand Up @@ -2180,13 +2180,13 @@
background-repeat: no-repeat !important;
}
.network-tree[src$="t.png"] {
background-image: url('data:image/gif;base64,R0lGODlhFAAaAPABADMzMwAAACH5BAUAAAEALAAAAAAUABoAAAIkjI+pG8APY5O0uorfzRzt3n1g5pSTOTJiSq1s5L6ajMW0YgcFADs=') !important;
background-image: url("data:image/gif;base64,R0lGODlhFAAaAPABADMzMwAAACH5BAUAAAEALAAAAAAUABoAAAIkjI+pG8APY5O0uorfzRzt3n1g5pSTOTJiSq1s5L6ajMW0YgcFADs=") !important;
}
.network-tree[src$="i.png"] {
background-image: url('data:image/gif;base64,R0lGODlhFAAaAPABADMzMwAAACH5BAUAAAEALAAAAAAUABoAAAIhjI+pG8APY5O0uorfzRzt3n1gJo6WGaJcqUJsy7ywIgcFADs=') !important;
background-image: url("data:image/gif;base64,R0lGODlhFAAaAPABADMzMwAAACH5BAUAAAEALAAAAAAUABoAAAIhjI+pG8APY5O0uorfzRzt3n1gJo6WGaJcqUJsy7ywIgcFADs=") !important;
}
.network-tree[src$="l.png"] {
background-image: url('data:image/gif;base64,R0lGODlhFAAaAPABADMzMwAAACH5BAUAAAEALAAAAAAUABoAAAIejI+pG8APY5O0uorfzRzt3n1g5pSTOabqyrbuC68FADs=') !important;
background-image: url("data:image/gif;base64,R0lGODlhFAAaAPABADMzMwAAACH5BAUAAAEALAAAAAAUABoAAAIejI+pG8APY5O0uorfzRzt3n1g5pSTOabqyrbuC68FADs=") !important;

This comment has been minimized.

Sign in to view

Copy link
@silverwind

silverwind Jul 19, 2016

Author Member

@Mottie there were some Styllint violations with these quotes which prevented me from committing. I wonder why the hook didn't prevent you too :)

This comment has been minimized.

Sign in to view

Copy link
@Mottie

Mottie Jul 19, 2016

Member

Sorry about that... the hook doesn't work in Windows for some reason.

This comment has been minimized.

Sign in to view

Copy link
@silverwind

silverwind Jul 19, 2016

Author Member

Ah, will have to check that out.

This comment has been minimized.

Sign in to view

Copy link
@Mottie

Mottie Jul 19, 2016

Member

We talked about the pre-commit hook before, but I remember you testing it and it wasn't working in Windows. I can't find where we discussed that.
}
/* octotree icons */
a.octotree_toggle:not(.octotree_loading) > span:after,
Expand Down Expand Up @@ -2303,7 +2303,7 @@
}
/* orange rss icon */
.blog-aside .octicon-rss, .dashboard-feed-icon.octicon-rss,
.nav-rss a .octicon-rss, a.feed-icon, #dashboard .octicon-rss {
a .octicon-rss, a.feed-icon {
color: #f93 !important;

This comment has been minimized.

Sign in to view

Copy link
@Mottie

Mottie Jul 19, 2016

Member

This change made the "public activity" feed icon orange

2016-07-18 20_06_37- mottie rob garrison

This comment has been minimized.

Sign in to view

Copy link
@silverwind

silverwind Jul 19, 2016

Author Member

Ah good find, I see you already fixed it. You could alternatively also just revert my change, I think explicit styling what should be orange might be better in the long run.

This comment has been minimized.

Sign in to view

Copy link
@Mottie

Mottie Jul 19, 2016

Member

True, but I think I'm done for tonight LOL... too many changes in rapid succession.

This comment has been minimized.

Sign in to view

Copy link
@silverwind

silverwind Jul 19, 2016

Author Member

No problem, reverted your last commit and fixed it myself :)

This comment has been minimized.

Sign in to view

Copy link
@un1versal

un1versal Jul 19, 2016 •
edited
Loading

Contributor

This change made the "public activity" feed icon orange

2016-07-18 20_06_37- mottie rob garrison

silverwind added a note 4 hours ago

Ah good find, I see you already fixed it. You could alternatively also just revert my change, I think explicit styling what should be orange might be better in the long run.

see 7aa4ae9#commitcomment-18293510
}
.featured-label {
Expand Down

0 comments on commit e590fd0

Please sign in to comment.