Allow testing building crowd_anki/dist when Pipfile.lock is changed #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aplaice
force-pushed
the
fetch_dependencies_github_action
branch
from
54357e1 to
17fcf00
Compare
Fix Stvad#182. The uploaded artifact is currently unused. We check for changes to both Pipfile and Pipfile.lock to avoid stale a Pipfile.lock. This will result in some false positive runs of this workflow, when we've, say, added a new script to Pipfile, without changing dependencies. We will also have false positives when only dev dependencies have been updated.
aplaice
force-pushed
the
fetch_dependencies_github_action
branch
from
17fcf00 to
7317130
Compare
aplaice
force-pushed
the
fetch_dependencies_github_action
branch
from
bee0d4d to
26f1ba8
Compare
|
Ugh, that didn't work (see: https://github.com/Stvad/CrowdAnki/actions/runs/5040054106/jobs/9038569945?pr=194 (Process substitution ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The uploaded artifact is currently unused.
Fix #182.
We check for changes to both Pipfile and Pipfile.lock to avoid stale a Pipfile.lock.
This will result in some false positive runs of this workflow, when we've, say, added a new script to Pipfile, without changing dependencies.
We will also have false positives when only dev dependencies have been updated.