Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update elFinderVolumeSFTPphpseclib.class.php #3483

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Conversation

sdwru
Copy link
Contributor

@sdwru sdwru commented Apr 29, 2022

Currently, this class does not work with symlinks at all. Permissions also don't work properly. Using Flysystem is not an option for me because that requires PHP v8. Older flysystem requires PHP v7.4 which is also not an option for me since I am stuck with v7.3 for now.

I ended up creating my own SFTP3phpseclib.class.php. I have edited this file with some of the changes I made to get symlinks sort of working. I am still testing it so this is just a start. It took me a long time to figure out how to get symlinks to show up so maybe this will help others struggling with this. I am using phpseclib v3 so I only tested these changes with that library.

I also made a bunch of changes to get permissions working properly. I may include that in a separate pull request after I test it more.

Currently, this class does not work with symlinks at all.  Permissions also don't work properly.  Using Flysystem is not an option for me because that requires PHP v8.  I ended up creating my own `SFTP3phpseclib.class.php`.  I have edited this file with some of the changes I made to get symlinks sort of working.  I am still testing it so this is just a start.  It took me a long time to figure out how to get symlinks to show up so maybe this will help others struggling with this.  I am using phpseclib v3 so I only tested these changes with that library.

I made a bunch of changes to get permissions working properly.  I may include that in a separate pull request after I test it more.
@nao-pon nao-pon merged commit cfc0b3b into Studio-42:master Aug 26, 2022
@nao-pon
Copy link
Member

nao-pon commented Aug 26, 2022

@sdwru thank you! I'm sorry to be late.

Bit-Code-Developer pushed a commit to Bit-Apps-Pro/elFinder that referenced this pull request Oct 22, 2023
Currently, this class does not work with symlinks at all.  Permissions also don't work properly.  Using Flysystem is not an option for me because that requires PHP v8.  I ended up creating my own `SFTP3phpseclib.class.php`.  I have edited this file with some of the changes I made to get symlinks sort of working.  I am still testing it so this is just a start.  It took me a long time to figure out how to get symlinks to show up so maybe this will help others struggling with this.  I am using phpseclib v3 so I only tested these changes with that library.

I made a bunch of changes to get permissions working properly.  I may include that in a separate pull request after I test it more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants