Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js:core] implementation of theme changer #2720

Closed
johnfort opened this issue Oct 16, 2018 · 8 comments
Closed

[js:core] implementation of theme changer #2720

johnfort opened this issue Oct 16, 2018 · 8 comments
Assignees

Comments

@johnfort
Copy link

Plz, add themesBasePath, themes, themes in preference and author (maybe parse comment in css (if exits)) of theme in about the software.

@johnfort
Copy link
Author

next request of fix (see screen)
opera _2018-10-16_231126_localhost

nao-pon added a commit that referenced this issue Oct 17, 2018
@nao-pon nao-pon self-assigned this Oct 17, 2018
@nao-pon nao-pon changed the title Add option themes and... [js:core] implementation of theme changer Oct 18, 2018
@johnfort
Copy link
Author

@nao-pon Plz, delete:

html.push(sep);
html.push('

'+fm.i18n('icons')+': Pixelmixer, Fugue, Icons8
');

I'm not use this icon...

@nao-pon
Copy link
Member

nao-pon commented Oct 19, 2018

@fortcms

I'm not use this icon...

They are included in the distribution package and can not be deleted.

@johnfort
Copy link
Author

@nao-pon Create new tab "Theme info" similar as 'Help'

@nao-pon
Copy link
Member

nao-pon commented Oct 19, 2018

@fortcms There is a tab "Theme".

fireshot capture 15 - img txt only_asdfa_elf_ - https___studio-42 github io_elfinder_ elf_l3_yxnkzme

@johnfort
Copy link
Author

johnfort commented Oct 19, 2018

@nao-pon I thought you would do differently.
Drop-down list of themes and their instant applyed. Then the theme photo is not needed!
And the tab in the "about topic" in the "help".

@nao-pon
Copy link
Member

nao-pon commented Oct 19, 2018

@johnfort
Copy link
Author

i will test it tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants