Enable the linuxArm32Hfp Native target #143
Conversation
lppedd
force-pushed
the
build/linux-hfp
branch
from
0b5f2d8
to
2cf198b
Compare
|
@ftomassetti you can review anytime. Had to adjust the readme. |
lppedd
force-pushed
the
build/linux-hfp
branch
from
0935a94
to
749872d
Compare
|
I would like to get #144 solved before merging other PRs |
|
@ftomassetti this one can wait, but #146 will block people using certain grammars. |
|
We are down to one, so I think that either way we will move forward in a matter of days |
| | | tvosX64 | | | ||
| | | tvosArm64 | | | ||
| | | iosArm64 | | | ||
|
|
||
| > :warning: The `linuxArm32Hfp` platform is deprecated |
There was a problem hiding this comment.
Why do we want to support it, if it is deprecated?
There was a problem hiding this comment.
@ftomassetti it is deprecated because it is still under evaluation. It may be supported officially in future versions.
Also, current users of linuxArm32Hfp might benefit from a antlr-kotlin release.
If we will remove it in the future, linuxArm32Hfp consumers will be able to use an older, but working, version of ANTLR.
There is no rumors of this target getting totally removed anytime soon.
There was a problem hiding this comment.
Ok, makes sense. I will merge this
|
In general it looks good but I would like to understand better why supporting a deprecated target: don't we risk having to remove support in the near future? If so, can we just avoid adding it in the first place? |
Other Kotlin libraries, like
kotlinx-serialization, had to enable back thelinuxArm32Hfptarget.That target is still present, so we should also build for it.
See Kotlin/kotlinx.serialization#2505