Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added variable mu per limb #5

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Conversation

ansue1234
Copy link
Contributor

Edit: Squashed Commits into 1

Just want to check whether my implementation is correct and whether it works for the unreleased examples.
Changes:

  • added mu attribute to elasticRod class
    changed the function definition of addLimb for soft robot class to include mu, but mu is an optional parameter with default of 0
  • tweaked contactForce class, between two limbs, use the max mu of the two limbs in contact (maybe average might be better? or so some more sophisticated logic in future)
    • In contactForce class, the option to use friction or not is now a boolean flag to be passed in
  • tweaked floorContactForceClass to use mu of limb when calculating force and jacobian (a bit unsure of the correctness of my implementation on this part)
    included one shell file
    • I find the shell files useful because I can choose which Cpp file in my workspace "custom_bots" to be robotDescription.cpp, change directory to build to build and link that file, change back to the root directory, and run ./dismech shell script in 1 command. Make life a little bit easier before we can create robots via XML or urdf.

@QuantuMope QuantuMope added the enhancement New feature or request label Nov 3, 2023
@QuantuMope
Copy link
Collaborator

Looks good for the most part, but I would like the friction coefficient for the floor to be readded.

It's very possible for the limbs and floor to have different friction coefficients. We don't want to remove this functionality.

@QuantuMope QuantuMope merged commit 3fc1b52 into StructuresComp:main Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants