Misc.Fixes 2 #198
Merged
Misc.Fixes 2 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #198 +/- ##
==========================================
+ Coverage 66.09% 67.86% +1.77%
==========================================
Files 51 51
Lines 2548 2483 -65
==========================================
+ Hits 1684 1685 +1
+ Misses 864 798 -66 ☔ View full report in Codecov by Sentry. |
alyst
commented
Apr 21, 2024
Maximilian-Stefan-Ernst
requested changes
Apr 22, 2024
reuse sigma^{-1}*sigma_0 product
* use sorted searches * use dict to map indicator to param index
* extract common code to calculate_lambda() * use 3-arg dot() * use in-place ops
avoid unnecessary allocations
* use eachcol() within comprehension
if the series don't converge
as symbolic Neumann series is a very comp.intensive operation
don't allow missing n_obs
* convert to param_range() which gets the range for a single matrix * use findfirst/findlast() instead of manual loop
* rename from get_matrix_derivative(): it's not a getter, and gradient is a better term * construct sparse matrix directly, which is much more efficient * parameters arg is not needed
|
Thanks again for very fast review! The next round of changes may substantially change some internal structs like RAMMatrices. So potentially you can release the current fixes as the new patch version. |
Maximilian-Stefan-Ernst
approved these changes
Apr 22, 2024
Maximilian-Stefan-Ernst
merged commit 71f3a89
into
StructuralEquationModels:devel
5 checks passed
|
Ah thanks for re-fixing the I-A computation^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second round of cherry-picking from #193.
This time there are:
AeqB = A == B; @test AeqBwe do@test A == Bdirectly, which provides better diagnostic when the test failsThese commits do not affect the API (except that
n_manandn_obsare now restricted toInt-- in all of their usages in the current code they are converted back to Int from Float64).