Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With my model I have hit the limit of the arguments that splatting supports (in particular, I was getting StackOverflowError in matrix derivative function).
So I've fixed the problematic spatting instances (
op(data...)
) with the faster alternativereduce(op, data)
.In particular, it is much faster for special cases like
hcat
, because there is a specialized version ofreduce(hcat, x)
.