Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Rename attributes within ConfusionMatrix metric. #807

Closed
1 of 3 tasks
czaloom opened this issue Oct 22, 2024 · 0 comments · Fixed by #825
Closed
1 of 3 tasks

ENH: Rename attributes within ConfusionMatrix metric. #807

czaloom opened this issue Oct 22, 2024 · 0 comments · Fixed by #825
Assignees

Comments

@czaloom
Copy link
Collaborator

czaloom commented Oct 22, 2024

Feature Type

  • Adding new functionality to valor

  • Changing existing functionality in valor

  • Removing existing functionality in valor

Problem Description

@jtjohnston brought up some concerns about how the ConfusionMatrix metric details hallucinations separately. The primary concern is that it is not fully clear how hallucinations relate to overall false-positives and how it relates to the confusion matrix value.

Feature Description

Under the confusion matrix metric:

  • Rename hallucinations to unmatched_predictions
  • Rename missing_predictions to unmatched_ground_truths

Additional Context

No response

@czaloom czaloom self-assigned this Oct 22, 2024
@czaloom czaloom changed the title ENH: Adjust ConfusionMatrix metric. ENH: Rename attributes within ConfusionMatrix metric. Dec 5, 2024
@czaloom czaloom linked a pull request Dec 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant