Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like pipeline is required to have a tokenizer property.
I added a tokenizer property, even though it's not being used for anything.
Notes that sentence-transformers model has their own tokenizer under property model.
in
mlserver-huggingface.common.py::load_pipeline_from_setting
functionWe are doing some modification to
tokenizer
whenmax_batch_size
is greater than 1.It also seems that inference server would deliberately set
max_batch_size
to be greater than 1Sentence-transformer model has their own way to handle
max_batch_size
.To avoid bug, we keep a tokenizer property in
StEmbeddingPipeline