Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Username in http(s) url should be encoded to URI format #32

Merged
merged 1 commit into from
Apr 12, 2016
Merged

Username in http(s) url should be encoded to URI format #32

merged 1 commit into from
Apr 12, 2016

Conversation

tunglam14
Copy link

Username, that include special characters (i.e: username is an email address [email protected]), must be URI encoded in build httpUrl for git clone.

@knownasilya knownasilya merged commit 819fd74 into Strider-CD:master Apr 12, 2016
@knownasilya
Copy link
Member

Thank you 👍

knownasilya pushed a commit that referenced this pull request Jul 20, 2016
v0.2.6
954162b 
- Username in http(s) url should be encoded to URI format #32
- Code cleanup/fix lint
- Use npm instead of make
- Add Travis config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tunglam14 @knownasilya